Skip to content

Comments

Change JSON RPC Error-32602 (Invalid Params) to return with http status code 200#4967

Merged
gfukushima merged 6 commits intohyperledger:mainfrom
gfukushima:32602-with-http-status-code-200
Jan 20, 2023
Merged

Change JSON RPC Error-32602 (Invalid Params) to return with http status code 200#4967
gfukushima merged 6 commits intohyperledger:mainfrom
gfukushima:32602-with-http-status-code-200

Conversation

@gfukushima
Copy link
Contributor

@gfukushima gfukushima commented Jan 20, 2023

PR description

This PR changes the JsonRpc http service to return the error -32602 (Invalid params) with a 200 http status code.

Fixed Issue(s)

Linked to #4747

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


### Breaking Changes

- Changed JsonRpc http service to return the error -32602 (Invalid params) with a 200 http status code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: from 400 to 200

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
@gfukushima gfukushima enabled auto-merge (squash) January 20, 2023 04:18
@gfukushima gfukushima merged commit 857db71 into hyperledger:main Jan 20, 2023
@gfukushima gfukushima deleted the 32602-with-http-status-code-200 branch March 23, 2023 22:59
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
…us code 200 (hyperledger#4967)

* Handle INVALID_PARAMS with a 200 http status code

* Change tests to expect INVALID_PARAMS with a 200 http status code

* Add change log entry

* Change test to handle jsonRPC result rather than raised exception

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
…us code 200 (hyperledger#4967)

* Handle INVALID_PARAMS with a 200 http status code

* Change tests to expect INVALID_PARAMS with a 200 http status code

* Add change log entry

* Change test to handle jsonRPC result rather than raised exception

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants